🐛 fix for users { * }: check for nil file data before returning path #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
providers/os/resources/privatekey.go
Outdated
| @@ -33,7 +32,7 @@ func (r *mqlPrivatekey) id() (string, error) { | |||
| // TODO: use path or hash depending on initialization | |||
|
|
|||
| file := r.GetFile() | |||
| if file.Error != nil { | |||
| if file.Error != nil || file.Data == nil { | |||
There was a problem hiding this comment.
I am a bit confused by this, it implies that the Error and Data might be nil at the same time
if that is the case, we should probably split those two checks, else return "", file.Error might evaluate to "", nil
There was a problem hiding this comment.
+1, we can return a custom error if file.Data == nil and just let users know that no file is provided
vjeffrey
force-pushed
the
vj/panic-users
branch
from
cd45268 to
1166f3c
Compare
preslavgerchev
approved these changes
Sep 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1724