Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 avoid printing home-path for root #1842

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

arlimus
Copy link
Member

@arlimus arlimus commented Sep 22, 2023

Root just uses the system path, so trying to print a home path that is an empty string is confusing and wrong.

Before:

image

After:

image

Root just uses the system path, so trying to print a home path that is an empty string is confusing and wrong.

Signed-off-by: Dominik Richter <[email protected]>
@arlimus arlimus requested a review from atomic111 September 22, 2023 04:21
Copy link
Member

@atomic111 atomic111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arlimus thank you for the improvement

@atomic111 atomic111 merged commit 3fae907 into main Sep 22, 2023
10 checks passed
@atomic111 atomic111 deleted the dom/no-empty-providers-path branch September 22, 2023 04:25
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants