🐛 pre-process known provider flags #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were getting errors about pre-processing failing when used in conjunction with full-fledged CLI commands. Example: If you didn't have `cnquery` installed and copy-pasted: ```bash cnquery run github org mondoohq --token github_.. -c ".." ``` ... you'd get an error about not being able to parse `--token`. This is a bit inefficient, but it at least results in a clean run for now. Signed-off-by: Dominik Richter <[email protected]>
chris-rock
approved these changes
Sep 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting errors about pre-processing failing when used in conjunction with full-fledged CLI commands.
Example: If you didn't have
cnqueryinstalled and copy-pasted:cnquery run github org mondoohq --token github_.. -c ".."... you'd get an error about not being able to parse
--token.This is a bit inefficient, but it at least results in a clean run for now.