🐛 Fix AWS VPC routetable id #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marius Kimmina <[email protected]>
mariuskimmina
force-pushed
the
fix-routetable-id
branch
from
6f55b30 to
788642f
Compare
vjeffrey
reviewed
Oct 2, 2023
| @@ -140,6 +140,10 @@ func (a *mqlAwsVpc) flowLogs() ([]interface{}, error) { | |||
| return flowLogs, nil | |||
| } | |||
|
|
|||
| func (a *mqlAwsVpcRoutetable) id() (string, error) { | |||
| return a.Id.Data, nil | |||
There was a problem hiding this comment.
this fixes the bug, thank you!
same comment as the others, id love to have a region prefix or something on here unless aws guarantees these ids are unique across regions.
that said, this fixes a bug, so im gonna go ahead and get this merged in
vjeffrey
approved these changes
Oct 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this bug during #1827
Before
Shows the same id twice
After