Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add incognito flag to run command #1912

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Sep 25, 2023

Fixes #1889

Fixes #1889

Signed-off-by: Christian Zunker <[email protected]>
@preslavgerchev
Copy link
Contributor

Why do we need to report anything for a run command, I would imagine that just executes the query and exits?

@czunker
Copy link
Contributor Author

czunker commented Sep 25, 2023

Why do we need to report anything for a run command, I would imagine that just executes the query and exits?

For most queries, that is true. And I do not need upstream to report something but to fetch the data for advisories, CVEs, ... We need to authenticate to the platform to get this information.

@preslavgerchev
Copy link
Contributor

Why do we need to report anything for a run command, I would imagine that just executes the query and exits?

For most queries, that is true. And I do not need upstream to report something but to fetch the data for advisories, CVEs, ... We need to authenticate to the platform to get this information.

makes sense, i didnt think of that

@vjeffrey vjeffrey merged commit 32f3551 into main Sep 26, 2023
10 checks passed
@vjeffrey vjeffrey deleted the christian/v9_fix_upstream branch September 26, 2023 06:08
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upstream config not handled correctly
3 participants