Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Install a specific provider version #1918

Merged
merged 8 commits into from
Sep 26, 2023
Merged

✨ Install a specific provider version #1918

merged 8 commits into from
Sep 26, 2023

Conversation

preslavgerchev
Copy link
Contributor

@preslavgerchev preslavgerchev commented Sep 25, 2023 •
edited
Loading

Allows users to install providers by just name or ver

➜ ~/go/bin/cnquery providers  install [email protected]                             
→ installing provider 'okta' version=9.0.0
→ successfully installed okta provider path=/Users/preslavgerchev/.config/mondoo/providers/okta version=9.0.0

➜ ~/go/bin/cnquery providers  install [email protected]
→ installing provider 'okta' version=9.0.1
FTL failed to install error="cannot find provider okta-9.0.1 under url https://releases.mondoo.com/providers/okta/9.0.1/okta_9.0.1_darwin_arm64.tar.xz"

There's an issue with the CLI pre-processing, I will look into it, seems unrelated to the changes in this PR

chris-rock
chris-rock reviewed Sep 25, 2023
View reviewed changes
apps/cnquery/cmd/providers.go Outdated Show resolved Hide resolved
apps/cnquery/cmd/providers.go Outdated Show resolved Hide resolved
chris-rock
chris-rock reviewed Sep 25, 2023
View reviewed changes
apps/cnquery/cmd/providers.go Outdated Show resolved Hide resolved
apps/cnquery/cmd/providers.go Outdated Show resolved Hide resolved
chris-rock
chris-rock approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot, cool stuff.

@chris-rock chris-rock merged commit 4b2f185 into main Sep 26, 2023
@chris-rock chris-rock deleted the preslav/providers-install branch September 26, 2023 08:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chris-rock chris-rock chris-rock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@preslavgerchev @chris-rock