Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 use gitlab mql group projects for project init #1921

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

vjeffrey
Copy link
Contributor

...i was able to reproduce the error that led to creating this pr earlier, and now i cannot. i do not understand why.

in any case, this is the error that was reported:

failed to create resource 'gitlab.project': GET https://gitlab.com/api/v4...
404 {message: 404 Project Not Found}

we were previously hitting the api every time we init-ed a project..this changes it to use the group projects. i kept on convincing myself this wasn't correct, but since we always require a group along with a project, it does still work. and it means we don't hit the api every time

Copy link
Member

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@arlimus arlimus merged commit 06be5cb into v8 Sep 25, 2023
9 checks passed
@arlimus arlimus deleted the vj/fix-gitlab-projectfetch branch September 25, 2023 20:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants