-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix handling of socketMap #1928
Conversation
This PR basically moves code from the port resource to the process resource to have the logic for the socketMap in one place. |
I tried this with a local, ssh, and running container connection. OS were Ubuntu 22.04 and Alpine 3.something. |
@arlimus Is this how you thought it should be? |
Sorry I'm late to respond @czunker ! I think it's good direction to move this to the process resource, as you are approaching it. A few things:
No need to press this for v9, I have updated the tags. |
@czunker Given that the primary issue for this PR is closed right now, I'd recommend we get to this after the other priority items are resolved first. |
8510eed
to
ce289d7
Compare
This PR now also fixes an issue, where I didn't see data with a debian 11. |
For the performance issue: |
Fixes #1434 Signed-off-by: Christian Zunker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome improvements! This should be green once rebased, nice job 🤘
ce289d7
to
e925a28
Compare
Fixes #1434