Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Avoid setting values to nil on GCP logging resource #1942

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

arlimus
Copy link
Member

@arlimus arlimus commented Sep 27, 2023

Fixes #1931

@arlimus arlimus requested a review from czunker September 27, 2023 03:32
@czunker
Copy link
Contributor

czunker commented Sep 27, 2023

Looking better now:

cnquery run gcp project mondoo-dev-262313 -c "gcp.project.logging.sink{*}" 
→ loaded configuration from /etc/opt/mondoo/mondoo.yml using source default
1 error occurred:
	* cannot convert primitive with NO type information
gcp.project.loggingservice.sink: {
  includeChildren: cannot convert primitive with NO type information
  projectId: cannot convert primitive with NO type information
  id: cannot convert primitive with NO type information
  storageBucket: null
  filter: cannot convert primitive with NO type information
  writerIdentity: cannot convert primitive with NO type information
  destination: cannot convert primitive with NO type information
}

The "cannot convert" messages will be addressed with #1943

Copy link
Contributor

@czunker czunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arlimus

@czunker czunker merged commit 0352fc9 into main Sep 27, 2023
10 checks passed
@czunker czunker deleted the dom/1931 branch September 27, 2023 06:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcp provider crashed when accessing an uninitialized resource
2 participants