🐛 avoid crashing terraform on unsupported plan calls #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happens when we call plan resources without operating on a Terraform plan. This needs better handling for unsupported or invalid data. I strongly recommend we instead inform users that there are no plan files via an error in the future. For now, create compatibility with v8 to get it release-ready. Signed-off-by: Dominik Richter <[email protected]>
vjeffrey
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
working better for sure! ⭐️
i am still seeing other errs
cnspec> terraform.settings
terraform.settings: terraform.settings id = terraform.settings
cnspec> terraform.settings { *}
1 error occurred:
* cannot convert primitive with NO type information
terraform.settings: {
requiredProviders: cannot convert primitive with NO type information
block: cannot convert primitive with NO type information
but we can address those in followup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happens when we call plan resources without operating on a Terraform plan. This needs better handling for unsupported or invalid data. I strongly recommend we instead inform users that there are no plan files via an error in the future. For now, create compatibility with v8 to get it release-ready.
Fixes #1866