Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix logjn #1965

Merged
merged 3 commits into from
Sep 28, 2023
Merged

🐛 fix logjn #1965

merged 3 commits into from
Sep 28, 2023

Conversation

chris-rock
Copy link
Member

@chris-rock chris-rock commented Sep 27, 2023 •
edited
Loading

This PR does:

  • switches asset { * } to a specific asset query
  • detects id and platform so that users see that information for managed clients
  • adds ip detection

As follow up, we need to ensure that os plugins are dynamically installed on first run

@arlimus arlimus mentioned this pull request Sep 28, 2023
Merged
@chris-rock chris-rock force-pushed the chris-rock/login-collect-asset-info branch from 38859c0 to ca5a444 Compare September 28, 2023 11:55
@chris-rock chris-rock force-pushed the chris-rock/login-collect-asset-info branch from ca5a444 to d2de666 Compare September 28, 2023 11:58
@chris-rock chris-rock marked this pull request as ready for review September 28, 2023 12:00
@vjeffrey vjeffrey merged commit f174cbe into main Sep 28, 2023
10 checks passed
@vjeffrey vjeffrey deleted the chris-rock/login-collect-asset-info branch September 28, 2023 17:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vjeffrey vjeffrey vjeffrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-rock @vjeffrey