⭐️ full IMDSv2 support for Amazon instances #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
force-pushed
the
vj/fix-identityparse-ec2
branch
from
c56fcd1 to
bb8c4dd
Compare
|
Amazon Linux cnquery shell ssh [email protected]
→ connected to Amazon Linux 2
___ _ __ __ _ _ _ ___ _ __ _ _
/ __| '_ \ / _` | | | |/ _ \ '__| | | |
| (__| | | | (_| | |_| | __/ | | |_| |
\___|_| |_|\__, |\__,_|\___|_| \__, |
mondoo™ |_| |___/ interactive shell
cnquery> asset.ids
asset.ids: [
0: "//platformid.api.mondoo.app/hostname/ip-10-0-101-112.ec2.internal"
1: "//platformid.api.mondoo.app/runtime/aws/ec2/v1/accounts/921877552404/regions/us-east-1/instances/i-03e3d4bbc86234179"
2: "//platformid.api.mondoo.app/runtime/ssh/hostkey/SHA256-SWlgTvT4v/KTfqqGirAdSpazoggXuRWvU8Kc/UPQnmM"
]Windows 2022 cnquery shell ssh [email protected]'
→ connected to Microsoft Windows Server 2022 Datacenter
___ _ __ __ _ _ _ ___ _ __ _ _
/ __| '_ \ / _` | | | |/ _ \ '__| | | |
| (__| | | | (_| | |_| | __/ | | |_| |
\___|_| |_|\__, |\__,_|\___|_| \__, |
mondoo™ |_| |___/ interactive shell
cnquery> asset.ids
asset.ids: [
0: "//platformid.api.mondoo.app/hostname/EC2AMAZ-9J7J697"
1: "//platformid.api.mondoo.app/runtime/aws/ec2/v1/accounts/921877552404/regions/us-east-1/instances/i-0d6c48ca58e8d8fce"
2: "//platformid.api.mondoo.app/runtime/ssh/hostkey/SHA256-LqOQnEb2c+qD0ObaLSh5m0pNjx+Zyc/fN1Pq6DhTh88"
] |
chris-rock
changed the title
vjeffrey
commented
Oct 4, 2023
chris-rock
force-pushed
the
vj/fix-identityparse-ec2
branch
from
04de2ce to
740f664
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1813
This change updates the platform detection to work well with IMDSv2 for both Linux and Windows. In addition it slickly tweaks the default platform ids: