Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐ Add new properties to aws.rds.dbInstances #2006

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

tas50
Copy link
Member

@tas50 tas50 commented Oct 1, 2023

Add a few important things for asset inventory.

  • Storage type
  • Storage IOPS
  • Storage amount allocated
  • Engine version
  • Availability zone
  • Creation Date
aws.rds.dbInstances: [
  0: aws.rds.dbinstance id="database-1" region="us-east-1" engine="postgres" engineVersion="15.3"
  1: aws.rds.dbinstance id="acg-basic" region="us-east-2" engine="mysql" engineVersion="8.0.28"
  2: aws.rds.dbinstance id="acg-read-replica" region="us-east-2" engine="mysql" engineVersion="8.0.28"
]
cnquery> aws.rds.dbInstances.first{*}
aws.rds.dbInstances.first: {
  publiclyAccessible: false
  id: "database-1"
  status: "available"
  multiAZ: false
  snapshots: [
    0: aws.rds.snapshot arn="FOO"
  ]
  region: "us-east-1"
  enhancedMonitoringResourceArn: "FOO"
  name: ""
  storageEncrypted: true
  arn: "FOO"
  tags: {
    devops-guru-default: "database-1"
  }
  engine: "postgres"
  dbInstanceIdentifier: "database-1"
  enabledCloudwatchLogsExports: []
  storageType: "gp2"
  securityGroups: [
    0: aws.ec2.securitygroup arn="FOO"
    1: aws.ec2.securitygroup arn="FOO"
  ]
  backupRetentionPeriod: 7
  availabilityZone: "us-east-1f"
  storageIops: 0
  dbInstanceClass: "db.m5.large"
  autoMinorVersionUpgrade: true
  deletionProtection: true
  creationDate: 2023-09-30 21:06:07.816 -0700 PDT
  storageAllocated: 200
  engineVersion: "15.3"
}

@tas50 tas50 force-pushed the tas50/rds_db_instance branch from 838c6c2 to e5f5bf5 Compare October 1, 2023 05:12
@github-actions

This comment has been minimized.

@tas50 tas50 force-pushed the tas50/rds_db_instance branch from e5f5bf5 to 44cef55 Compare October 1, 2023 06:06
@tas50 tas50 changed the title Add new properties to aws.rds.dbInstances ⭐ Add new properties to aws.rds.dbInstances Oct 2, 2023
"dbInstanceClass": llx.StringData(convert.ToString(dbInstance.DBInstanceClass)),
"dbInstanceIdentifier": llx.StringData(convert.ToString(dbInstance.DBInstanceIdentifier)),
"deletionProtection": llx.BoolData(dbInstance.DeletionProtection),
"enabledCloudwatchLogsExports": llx.ArrayData(stringSliceInterface, types.String),
"engine": llx.StringData(convert.ToString(dbInstance.Engine)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use can use llx.StringDataPtr here

Add a few important things for asset inventory.
- Storage type
- Storage IOPS
- Storage amount allocated
- Engine Version
- Availability zone
- Creation Date

Signed-off-by: Tim Smith <[email protected]>
@tas50 tas50 force-pushed the tas50/rds_db_instance branch from 44cef55 to 999ae27 Compare October 2, 2023 16:23
Signed-off-by: Tim Smith <[email protected]>
@vjeffrey vjeffrey merged commit fda5ca6 into main Oct 2, 2023
@vjeffrey vjeffrey deleted the tas50/rds_db_instance branch October 2, 2023 16:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants