🐛 aws and terraform resource fixes #2051
Conversation
vjeffrey
changed the title
vjeffrey
changed the title
vjeffrey
changed the title
providers/aws/resources/aws_s3.go
Outdated
| @@ -198,7 +204,7 @@ func (a *mqlAwsS3Bucket) policy() (*mqlAwsS3BucketPolicy, error) { | |||
| } | |||
|
|
|||
| // no bucket policy found, return nil for the policy | |||
| return &mqlAwsS3BucketPolicy{}, nil | |||
| return nil, errors.New("no policy found") | |||
There was a problem hiding this comment.
why are we returning an error and not just nil?
There was a problem hiding this comment.
hmm, good point. ill check that
There was a problem hiding this comment.
I think a NilData would be great because no policy is defined.
There was a problem hiding this comment.
fyi: we might have to set the field in this case (ie: TValue[T]{State: StateIsNull | StateIsSet, Error: err}). The hard thing here is that I had a hard time detecting with go if something is actually nil, because the nil gets wrapped in other types. I'll help solve this in the future to make it clear, but for now just set the TValue manually and return nil, nil if you need this :)
There was a problem hiding this comment.
👍 pushed up the fix - er, actually, nevermind - pushing up fix in a few
There was a problem hiding this comment.
ugh, this resource is giving me issues when nil
cnquery> aws.s3.buckets { policy.id}
1 error occurred:
* cannot cast resource to resource type: <nil>
*
````
99017b5 to
8f23fd7
Compare
fixes #2044
run cnquery scan aws and cnquery scan terraform against the server with the asset overview policy is now error free
fixes #2003