Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Continue scanning when connect to one asset fails #2081

Merged
merged 1 commit into from
Oct 4, 2023
Merged

🐛 Continue scanning when connect to one asset fails #2081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/assets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func detectAssets(runtime *Runtime, assetCandidates []*inventory.Asset, upstream
Upstream: upstreamConfig,
})
if err != nil {
return err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we at least log the error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had this in a previous version, but then it showed up twice here:

→ discover related assets for 1 asset(s)
x failed to connect to asset error="rpc error: code = Unknown desc = GET https://ghcr.io/v2/mondoohq/mondoo-operator/manifests/sha256-34e4bc26bf44ae1dddab394f5e9449664d6fe3a4.sig: MANIFEST_UNKNOWN: manifest unknown" asset=
x unable to connect to asset error="rpc error: code = Unknown desc = GET https://ghcr.io/v2/mondoohq/mondoo-operator/manifests/sha256-34e4bc26bf44ae1dddab394f5e9449664d6fe3a4.sig: MANIFEST_UNKNOWN: manifest unknown"
→ synchronize assets

So, I removed the logging.

continue
}
// Use the updated asset
assetCandidates[i] = runtime.Provider.Connection.Asset
Expand Down
Loading