Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix providers-sdk configure to support providers with dashes in their name. #2085

Merged
merged 1 commit into from
Oct 5, 2023
Merged

🐛 Fix providers-sdk configure to support providers with dashes in their name. #2085

merged 1 commit into from
Oct 5, 2023

Conversation

preslavgerchev
Copy link
Contributor 

go run ./providers-sdk/v1/util/configure/configure.go -f providers.yaml -o providers/builtin_dev.go
→ (1/3) configured builtin providers path=providers/builtin_dev.go providers=["google-workspace"]
DBG build provider 1/1 provider=google-workspace
→ (2/3) built providers providers=["google-workspace"]
DBG go mod tidy
→ (3/3) rewired dependencies/files path=providers/builtin_dev.go providers=["google-workspace"]

@preslavgerchev preslavgerchev force-pushed the preslav/fix-providers-configure branch from af3a924 to b397598 Compare October 4, 2023 16:27
czunker
czunker approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@czunker czunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @preslavgerchev

@czunker czunker merged commit 8dd5b36 into main Oct 5, 2023
10 checks passed
@czunker czunker deleted the preslav/fix-providers-configure branch October 5, 2023 04:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@czunker czunker czunker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@preslavgerchev @czunker