🐛 switch providers after CLI parsing #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Early runtime checks can cause providers to switch. For example: A user may start with the `aws` provider, but really want to user the `os` provider to scan an instance in AWS: ```bash cnquery shell aws ec2 instance-connect ec2-user@i-1234abc --region us-east-1 --profile home ``` In the above example, we use the `aws` provider to parse the CLI. However, after that it's all about handing off the actual asset to the `os` provider to execute the scan. Signed-off-by: Dominik Richter <[email protected]>
vjeffrey
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
[10/10/23 16:44:30] ❯ go run apps/cnquery/cnquery.go shell aws ec2 instance-connect ec2-user@i-06a663a52ab28ca41 --region us-east-1 --profile home
→ no Mondoo configuration file provided, using defaults
→ connected to Amazon Linux 2023
___ _ __ __ _ _ _ ___ _ __ _ _
/ __| '_ \ / _` | | | |/ _ \ '__| | | |
| (__| | | | (_| | |_| | __/ | | |_| |
\___|_| |_|\__, |\__,_|\___|_| \__, |
mondoo™ |_| |___/ interactive shell
cnquery> asset { * }
1 error occurred:
* To use this resource, you must authenticate with Mondoo Platform.
To learn how, read:
https://mondoo.com/docs/cnspec/cnspec-adv-install/registration/
asset: {
kind: "baremetal"
build: ""
version: "2023"
title: "Amazon Linux 2023, bare metal"
...
|
this is working great, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early runtime checks can cause providers to switch. For example: A user may start with the
awsprovider, but really want to user theosprovider to scan an instance in AWS:In the above example, we use the
awsprovider to parse the CLI. However, after that it's all about handing off the actual asset to theosprovider to execute the scan.Related to #2166