Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix default providers IDs #3103

Merged
merged 2 commits into from
Jan 23, 2024
Merged

🐛 fix default providers IDs #3103

merged 2 commits into from
Jan 23, 2024

Conversation

imilchev
Copy link
Member

makes sure we are not installing the same provider version over and over

Signed-off-by: Ivan Milchev <[email protected]>
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @imilchev

Copy link
Contributor

github-actions bot commented Jan 23, 2024

Test Results

742 tests  ±0   742 ✅ ±0   12s ⏱️ ±0s
 83 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 6894f3e. ± Comparison against base commit 3ef716e.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-01-22_09:53:55.50566324_+0100_CET_m=+0.000895769
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-01-22_09:53:55.50566324_+0100_CET_m=+0.000895769
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-01-22_09:53:55.50566324_+0100_CET_m=+0.000895769#01
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-01-22_13:18:46.364798094_+0100_CET_m=+0.001130520
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-01-22_13:18:46.364798094_+0100_CET_m=+0.001130520
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-01-22_13:18:46.364798094_+0100_CET_m=+0.001130520#01

♻️ This comment has been updated with latest results.

Signed-off-by: Ivan Milchev <[email protected]>
@imilchev imilchev merged commit 5b15cb4 into main Jan 23, 2024
12 checks passed
@imilchev imilchev deleted the ivan/fix-provider-install branch January 23, 2024 16:25
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants