Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 make panic handler more flexible to allow ui message logging #3137

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

chris-rock
Copy link
Member

@chris-rock chris-rock commented Jan 27, 2024

We've seen some cases where panics happened in our packer provider. Therefore we want to introduce the panic handler there. Beside pure reporting, the packer plugin would like to hook into the panic handler and print the panic via the packer UI printer. This allows users to define custom handler.

Copy link
Contributor

Test Results

744 tests  ±0   744 ✅ ±0   12s ⏱️ ±0s
 83 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit bdf942f. ± Comparison against base commit c360d7e.

Copy link
Contributor

@scottford-io scottford-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chris-rock chris-rock merged commit 99ef99a into main Jan 29, 2024
12 checks passed
@chris-rock chris-rock deleted the chris-rock/panic-handler-fn branch January 29, 2024 15:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants