Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Retry login command when concurrent IAM updates are detected #3151

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

jaym
Copy link
Contributor

@jaym jaym commented Jan 29, 2024

If the server returns aborted for RegisterAgent, that means it aborted the change because of concurrent writes to the IAM policy, likely meaning concurrent registrations. Clients are safe to backoff and retry in this case.

If the server returns aborted for RegisterAgent, that means it aborted
the change because of concurrent writes to the IAM policy, likely
meaning concurrent registrations. Clients are safe to backoff and
retry in this case.
Copy link
Contributor

github-actions bot commented Jan 29, 2024

Test Results

744 tests  ±0   744 ✅ ±0   12s ⏱️ -1s
 83 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 7016a28. ± Comparison against base commit a62e09b.

This pull request removes 6 and adds 6 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/0001-01-01_00:53:28_+0053_LMT
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_16:23:37_+0053_LMT
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_16:30:07_+0100_CET
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-01-26_08:49:51.575504361_+0100_CET_m=+0.007844955
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-01-26_08:49:51.575504361_+0100_CET_m=+0.007844955
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-01-26_08:49:51.575504361_+0100_CET_m=+0.007844955#01
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/0001-01-01_00:00:00_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_15:30:07_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_15:30:09_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-01-27_15:13:56.544851117_+0000_UTC_m=+0.009805760
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-01-27_15:13:56.544851117_+0000_UTC_m=+0.009805760
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-01-27_15:13:56.544851117_+0000_UTC_m=+0.009805760#01

♻️ This comment has been updated with latest results.

Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition @jaym

@chris-rock chris-rock merged commit f493c37 into main Jan 29, 2024
12 checks passed
@chris-rock chris-rock deleted the jdm/retry-login branch January 29, 2024 21:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants