🧹 providers coordinator v2 #3218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Milchev <[email protected]>
Signed-off-by: Ivan Milchev <[email protected]>
Signed-off-by: Ivan Milchev <[email protected]>
imilchev
force-pushed
the
ivan/coordinator-v2
branch
from
298e1c7 to
bf90bcd
Compare
Signed-off-by: Ivan Milchev <[email protected]>
Signed-off-by: Ivan Milchev <[email protected]>
This was referenced Feb 6, 2024
jaym
reviewed
Feb 6, 2024
| @@ -30,13 +36,26 @@ type AssetWithError struct { | |||
|
|
|||
| type DiscoveredAssets struct { | |||
| platformIds map[string]struct{} | |||
| Assets []*AssetWithRuntime | |||
| Errors []*AssetWithError | |||
| // Assets []*AssetWithRuntime | |||
jaym
reviewed
Feb 6, 2024
| RootAssets map[*inventory.Asset]*RootAsset | ||
| } | ||
|
|
||
| func (d *DiscoveredAssets) AddRoot(root *inventory.Asset, coordinator providers.Coordinator, runtime *providers.Runtime) bool { |
There was a problem hiding this comment.
runtime isn't used. is that expected?
jaym
reviewed
Feb 6, 2024
| log.Debug().Str("asset", discoveredAssets.Assets[0].Asset.Name).Msg("Overriding asset name with --asset-name flag") | ||
| discoveredAssets.Assets[0].Asset.Name = invAssets[0].Name | ||
| } | ||
| // if len(discoveredAssets.Assets) == 1 && invAssets[0].Name != "" && invAssets[0].Name != discoveredAssets.Assets[0].Asset.Name { |
|
Thank you for taking a stab at this! We are motivated by random provider shutdowns across the system and by supporting multiple scans at the same time. We'll have a separate call to go over a discussion of this, so we will keep this PR as draft until then. |
|
we are fixing this by getting rid of ephemeral providers and making sure we have a more robust provider management system. Closing this one |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to allow creating local coordinators with a parent coordinator. The way the code is setup is: