Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 simplify shell command #3221

Merged
merged 1 commit into from
Feb 7, 2024
Merged

🧹 simplify shell command #3221

merged 1 commit into from
Feb 7, 2024

Conversation

imilchev
Copy link
Member

@imilchev imilchev commented Feb 6, 2024

no need to do a connect here since that is already done in DiscoverAssets this improves the responsivess of the shell command

Signed-off-by: Ivan Milchev <[email protected]>
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Test Results

761 tests  ±0   761 ✅ ±0   24s ⏱️ ±0s
 85 suites ±0     0 💤 ±0 
  2 files   ±0     0 ❌ ±0 

Results for commit 5ddbe4a. ± Comparison against base commit c4adb50.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-06_13:46:03.06051361_+0000_UTC_m=+0.008180352
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-06_13:46:03.06051361_+0000_UTC_m=+0.008180352
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-06_13:46:03.06051361_+0000_UTC_m=+0.008180352#01
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-06_12:29:41.58632262_+0000_UTC_m=+0.015839845
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-06_12:29:41.58632262_+0000_UTC_m=+0.015839845
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-06_12:29:41.58632262_+0000_UTC_m=+0.015839845#01

@imilchev imilchev merged commit 4d9e59e into main Feb 7, 2024
14 checks passed
@imilchev imilchev deleted the ivan/simplify-shell branch February 7, 2024 10:16
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants