Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 make sure the root asset runtime is closed #3289

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

imilchev
Copy link
Member

there was 1 case where the root asset runtime wasn't closed when it should have been. I also moved the close in a defer because it's best to close the connection at the end of the loop instead of before processing the discovered assets. If we do it at the end, we will be properly re-using the root asset MQL cache after #3274 merges

@imilchev imilchev force-pushed the ivan/asset-root-runtime-close branch from 2ccaaab to eaa5b26 Compare February 13, 2024 14:26
Copy link
Contributor

github-actions bot commented Feb 13, 2024

Test Results

2 745 tests  ±0   2 744 ✅ ±0   50s ⏱️ -1s
  186 suites ±0       1 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit d8fbec9. ± Comparison against base commit 3e13eee.

This pull request removes 6 and adds 6 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/0001-01-01_00:53:28_+0053_LMT
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_16:23:37_+0053_LMT
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_16:30:07_+0100_CET
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-14_11:51:20.462515947_+0100_CET_m=+0.013459540
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-14_11:51:20.462515947_+0100_CET_m=+0.013459540
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-14_11:51:20.462515947_+0100_CET_m=+0.013459540#01
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/0001-01-01_00:00:00_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_15:30:07_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestRawData_JSON/292277026596-12-04_15:30:09_+0000_UTC
go.mondoo.com/cnquery/v10/llx ‑ TestSuccess/2024-02-14_10:27:25.990481361_+0000_UTC_m=+0.009106256
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-14_10:27:25.990481361_+0000_UTC_m=+0.009106256
go.mondoo.com/cnquery/v10/llx ‑ TestTruthy/2024-02-14_10:27:25.990481361_+0000_UTC_m=+0.009106256#01

♻️ This comment has been updated with latest results.

@imilchev imilchev force-pushed the ivan/asset-root-runtime-close branch from eaa5b26 to 054df39 Compare February 13, 2024 14:30
@imilchev imilchev force-pushed the ivan/asset-root-runtime-close branch from 054df39 to d8fbec9 Compare February 14, 2024 11:19
@imilchev imilchev merged commit f9a4c27 into main Feb 14, 2024
14 checks passed
@imilchev imilchev deleted the ivan/asset-root-runtime-close branch February 14, 2024 11:33
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants