⭐ Draft: Enhancing Users Key Metadata retrieval (aws) #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hossein Rouhani <[email protected]>
Signed-off-by: Hossein Rouhani <[email protected]>
HRouhani
changed the title
tas50
changed the title
tas50
reviewed
Mar 5, 2024
| @@ -1662,6 +1662,10 @@ resources: | |||
| desc: | | |||
| Use the `aws.iam` resource to assess the configuration of the AWS IAM service. The resource provides a list of `aws.iam.user` resources representing GuardDuty Detectors deployed across all enabled regions. | |||
| fields: | |||
| accessKeyMetadata: | |||
| min_mondoo_version: latest | |||
There was a problem hiding this comment.
Suggested change
| min_mondoo_version: latest | |
| min_mondoo_version: 9.0.0 |
tas50
reviewed
Mar 5, 2024
| accessKeyMetadata: | ||
| min_mondoo_version: latest | ||
| accessKeys: | ||
| min_mondoo_version: latest |
There was a problem hiding this comment.
Suggested change
| min_mondoo_version: latest | |
| min_mondoo_version: 9.0.0 |
tas50
reviewed
Mar 5, 2024
| accessKeyId: {} | ||
| createDate: {} | ||
| status: {} | ||
| min_mondoo_version: latest |
There was a problem hiding this comment.
Suggested change
| min_mondoo_version: latest | |
| min_mondoo_version: 9.0.0 |
tas50
reviewed
Mar 5, 2024
| @@ -1817,6 +1843,9 @@ resources: | |||
| accessKey2LastUsedDate: {} | |||
| accessKey2LastUsedRegion: {} | |||
| accessKey2LastUsedService: {} | |||
| accessKeyMetadata: | |||
| min_mondoo_version: latest | |||
There was a problem hiding this comment.
Suggested change
| min_mondoo_version: latest | |
| min_mondoo_version: 9.0.0 |
HRouhani
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems:
it seems it fetch access keys for one specific IAM user, not for all users
need to check if a.Name.Data returns all usernames, or there is another mechanism in place that calls accessKeys() multiple times
The modified function, by explicitly handling each relevant field of the access key metadata, might offer better clarity and maintainability, especially in contexts where specific data handling or additional processing is required for each field.
Goals:
The motivation behind this approach was to enable a direct comparison between data obtained from aws.iam.usercredentialreportentry and aws.iam.accessKey through an MQL query, thereby facilitating a more comprehensive data analysis and correlation within the AWS IAM framework.