-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⭐️ new whois resource for network provider #4163
Draft
chris-rock
wants to merge
1
commit into
main
Choose a base branch
from
chris-rock/whois
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
force-pushed
the
chris-rock/whois
branch
from
June 1, 2024 20:20
d18dbdb
to
17a8a18
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
chris-rock
force-pushed
the
chris-rock/whois
branch
from
June 1, 2024 20:23
17a8a18
to
e451cca
Compare
chris-rock
force-pushed
the
chris-rock/whois
branch
from
June 1, 2024 20:32
e451cca
to
168dd16
Compare
tas50
requested changes
Jun 1, 2024
tas50
reviewed
Jun 1, 2024
chris-rock
force-pushed
the
chris-rock/whois
branch
from
June 2, 2024 07:08
168dd16
to
d8141eb
Compare
chris-rock
force-pushed
the
chris-rock/whois
branch
from
June 2, 2024 07:17
d8141eb
to
aeda9c8
Compare
This comment has been minimized.
This comment has been minimized.
This is only partially working for
Is this something we need? According to the used library, that should work. Or worked before? https://github.com/likexian/whois-parser/blob/master/testdata/noterror/de_google.de |
@czunker Great catch. I will update the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add whois resource to the network provider.
You can also ask for specific domains: