🐛 Fix endless KMS retrieval loop. #4548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Preslav <[email protected]>
Test Results3 097 tests 3 096 ✅ 1m 46s ⏱️ Results for commit 7ed08e1. |
chris-rock
approved these changes
Aug 13, 2024
| @@ -65,7 +65,7 @@ func (a *mqlAwsKms) getKeys(conn *connection.AwsConnection) []*jobpool.Job { | |||
| if Is400AccessDeniedError(err) { | |||
| log.Warn().Str("region", regionVal).Msg("error accessing region for AWS API") | |||
| } | |||
| continue | |||
| break | |||
There was a problem hiding this comment.
Can we check if we have more of those case?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an err happens when we're fetching KMS key, we continue and do not break. This means we get to retry again, however if the error is consistent (say a 403) we will never exit this loop. Instead, let's break out of the loop if we encounter an error.