Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐️ Make following redirects configurable for http.get resource #5011

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jaym
Copy link
Contributor

@jaym jaym commented Dec 19, 2024

By default, we will not follow redirects. You can follow redirects with a flag:

go run ./apps/cnquery -- shell host --follow-redirects http://mondoo.com

This string is used to make requests. Having the port in the url breaks
http to https redirects
@jaym jaym force-pushed the jdm/exclude-standard-port branch from 0506e6d to 5a4613d Compare December 19, 2024 16:22
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Test Results

3 200 tests   3 198 ✅  1m 42s ⏱️
  379 suites      2 💤
   29 files        0 ❌

Results for commit 142141c.

♻️ This comment has been updated with latest results.

@jaym jaym changed the title 🐛 Exclude standard ports from url string ⭐️ Make following redirects configurable for http.get resource Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant