Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 add extensions values to defender for containers resource #5042

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

vjeffrey
Copy link
Contributor

for #5000

@mm-weber can you check if this is the data that you need/if this works for you?

Copy link
Contributor

github-actions bot commented Dec 26, 2024

Test Results

3 205 tests  ±0   3 202 ✅ ±0   1m 47s ⏱️ +3s
  379 suites ±0       3 💤 ±0 
   29 files   ±0       0 ❌ ±0 

Results for commit f6bec05. ± Comparison against base commit 65de8c8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@mm-weber mm-weber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried and tested.
Good stuff!
Thank you @vjeffrey !

@vjeffrey vjeffrey marked this pull request as ready for review December 31, 2024 16:03
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vjeffrey I added a small improvement for the json mapping

providers/azure/resources/cloud_defender.go Outdated Show resolved Hide resolved
@vjeffrey vjeffrey force-pushed the vj/extensionsdefendercont branch from b30f93f to f6bec05 Compare December 31, 2024 22:58
@vjeffrey vjeffrey merged commit 4f5a6e0 into main Jan 3, 2025
17 checks passed
@vjeffrey vjeffrey deleted the vj/extensionsdefendercont branch January 3, 2025 23:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants