Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix loading private key from inventory #5044

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

afiune
Copy link
Contributor

@afiune afiune commented Dec 27, 2024

Similar to #5004

@afiune afiune requested review from imilchev and jaym December 27, 2024 13:45
Copy link
Contributor

github-actions bot commented Dec 27, 2024

Test Results

3 207 tests  +1   3 204 ✅ +1   1m 45s ⏱️ -3s
  379 suites ±0       3 💤 ±0 
   29 files   ±0       0 ❌ ±0 

Results for commit 8e61f82. ± Comparison against base commit 2b40eec.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v11/providers/github/connection ‑ TestGithubValidConnection
go.mondoo.com/cnquery/v11/providers/github/connection ‑ TestGithubValidConnection_Password
go.mondoo.com/cnquery/v11/providers/github/connection ‑ TestGithubValidConnection_Private_Key

♻️ This comment has been updated with latest results.

Signed-off-by: Salim Afiune Maya <[email protected]>
@vjeffrey
Copy link
Contributor

have all authentication methods been tested on cli to ensure everything is working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants