Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐️ Add tags to objectref #5083

Merged
merged 2 commits into from
Jan 10, 2025
Merged

⭐️ Add tags to objectref #5083

merged 2 commits into from
Jan 10, 2025

Conversation

jaym
Copy link
Contributor

@jaym jaym commented Jan 9, 2025

We can use the tags to provide additional metadata for variants like what icon to use and what title to show

An example:

queries:
  - uid: mondoo-edr-policy-ensure-edr-agent-is-installed
    title: Ensure EDR Agent is installed
    variants:
        - uid: mondoo-edr-policy-ensure-edr-agent-is-installed-macos
          tags:
            mondoo.com/filter-title: macos
        - uid: mondoo-edr-policy-ensure-edr-agent-is-installed-linux
          tags:
            mondoo.com/filter-title: linux
        - uid: mondoo-edr-policy-ensure-edr-agent-is-installed-windows
          tags:
            mondoo.com/filter-title: windows

We can use the tags to provide additional metadata for variants like
what icon to use and what title to show

An example:
```
queries:
  - uid: mondoo-edr-policy-ensure-edr-agent-is-installed
    title: Ensure EDR Agent is installed
    variants:
        - uid: mondoo-edr-policy-ensure-edr-agent-is-installed-macos
          tags:
            mondoo.com/filter-title: macos
        - uid: mondoo-edr-policy-ensure-edr-agent-is-installed-linux
          tags:
            mondoo.com/filter-title: linux
        - uid: mondoo-edr-policy-ensure-edr-agent-is-installed-windows
          tags:
            mondoo.com/filter-title: windows
```
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Results

3 207 tests  ±0   3 203 ✅ ±0   1m 50s ⏱️ +6s
  379 suites ±0       4 💤 ±0 
   29 files   ±0       0 ❌ ±0 

Results for commit 5347069. ± Comparison against base commit 7fbf9ae.

Copy link
Contributor

@czunker czunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Could you please add the example from the PR description to the code, when we already have some example variant somewhere? I'm not sure we have something like this already.

@jaym jaym merged commit d19b449 into main Jan 10, 2025
7 checks passed
@jaym jaym deleted the jdm/add-tags-to-objref branch January 10, 2025 16:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants