🧹 Fix flaky variant cycle test. (#945)

mondoohq · Nov 10, 2023 · 3ed6c68 · 3ed6c68
1 parent f66af37
commit 3ed6c68
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/policy/bundle.go b/policy/bundle.go
@@ -612,7 +612,7 @@ const (
 )
 
 var ErrVariantCycleDetected = func(mrn string) error {
-	return fmt.Errorf("variant cycle in %s detected", mrn)
+	return fmt.Errorf("variant cycle detected in %s", mrn)
 }
 
 func detectVariantCycles(queries map[string]*explorer.Mquery) error {

diff --git a/policy/policy_test.go b/policy/policy_test.go
@@ -369,7 +369,7 @@ queries:
 		pInitial := bundleInitial.Policies[0]
 		pInitial.InvalidateLocalChecksums()
 		_, err = bundleInitial.Compile(context.Background(), schema, nil)
-		require.Equal(t, policy.ErrVariantCycleDetected("//local.cnspec.io/run/local-execution/queries/variant1"), err)
+		require.Contains(t, err.Error(), "variant cycle detected")
 	}
 
 	{
@@ -401,6 +401,6 @@ queries:
 		pInitial := bundleInitial.Policies[0]
 		pInitial.InvalidateLocalChecksums()
 		_, err = bundleInitial.Compile(context.Background(), schema, nil)
-		require.Equal(t, policy.ErrVariantCycleDetected("//local.cnspec.io/run/local-execution/queries/variant1"), err)
+		require.Contains(t, err.Error(), "variant cycle detected")
 	}
 }