🧹 Prevent nil panic when recording is not set

In case recording isn't specififed during scanner initialisation, set the NullRecording Signed-off-by: Christian Zunker <[email protected]>
mondoohq · Nov 17, 2023 · d8a5bd6 · d8a5bd6
1 parent e25ee23
commit d8a5bd6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/policy/scan/local_scanner.go b/policy/scan/local_scanner.go
@@ -102,6 +102,10 @@ func NewLocalScanner(opts ...ScannerOption) *LocalScanner {
 		opts[i](ls)
 	}
 
+	if ls.recording == nil {
+		ls.recording = providers.NullRecording{}
+	}
+
 	return ls
 }
 

diff --git a/policy/scan/local_scanner_test.go b/policy/scan/local_scanner_test.go
@@ -100,3 +100,12 @@ func TestCreateAssetList(t *testing.T) {
 		require.Equal(t, "mondoo-operator-123", candidates[2].asset.ManagedBy)
 	})
 }
+
+func TestDefaultConfig(t *testing.T) {
+	t.Run("without opts", func(t *testing.T) {
+		scanner := NewLocalScanner()
+		require.NotNil(t, scanner)
+
+		require.Equal(t, providers.NullRecording{}, scanner.recording)
+	})
+}