🧹 decouple checkin from service startup #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Milchev <[email protected]>
imilchev
commented
Nov 20, 2024
| @@ -17,7 +17,7 @@ import ( | |||
| ) | |||
|
|
|||
| func Serve(timer time.Duration, splay time.Duration, handler JobRunner) { | |||
| isIntSess, err := svc.IsAnInteractiveSession() | |||
| isIntSess, err := svc.IsWindowsService() | |||
There was a problem hiding this comment.
this call is deprecated so I replaced it with its successor
chris-rock
approved these changes
Nov 20, 2024
| @@ -43,7 +43,9 @@ func (c *checkinPinger) Start() { | |||
| } | |||
|
|
|||
| // run check-in once on startup | |||
| runCheckIn() | |||
| go func() { | |||
| runCheckIn() | |||
There was a problem hiding this comment.
do we need to protect us from running multiple of those go routines in parallel? This should always only run once, we do not need to queue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the check-in is not blocking service startup. It now happens in the background