🧹 apply runtime env labels for discovered assets #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Milchev <[email protected]>
imilchev
force-pushed
the
ivan/k8s-cicd
branch
from
f58a489 to
daf9f22
Compare
vjeffrey
reviewed
Oct 3, 2023
| justAssets := []*inventory.Asset{} | ||
| for _, asset := range assets { | ||
| asset.asset.KindString = asset.asset.GetPlatform().Kind | ||
| for k, v := range runtimeLabels { |
There was a problem hiding this comment.
do we not wanna check if its an automated env before applying all these? (saw that we have that check in v8)
There was a problem hiding this comment.
if opts.AutoDetectCICDCategory && runtimeEnv.IsAutomatedEnv() || opts.Category == "cicd" {
There was a problem hiding this comment.
we cannot check this in the same way in this part of the code. I am now checking if the root asset is ci/cd. This should indicate that we are doing a ci/cd scan
Signed-off-by: Ivan Milchev <[email protected]>
benr
approved these changes
Oct 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is needed for ci/cd assets