Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 create a resilient v8 and v9+ vuln report #853

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

arlimus
Copy link
Member

@arlimus arlimus commented Oct 17, 2023

We recently hotfixed an issue that caused the report not to show on v9+, because older v8 code-paths were taken: #850

When the upstream reporting eventually switches over to use asset instead of platform, this hotfix will fail. This PR create a more resilient approach to the vulnerability report, supporting both v8 and v9+

We recently hotfixed an issue that caused the report not to show on v9+, because older v8 code-paths were taken: #850

When the upstream reporting eventually switches over to use `asset` instead of `platform`, this hotfix will fail. This PR create a more resilient approach to the vulnerability report, supporting both v8 and v9+

Signed-off-by: Dominik Richter <[email protected]>
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @arlimus

@chris-rock chris-rock merged commit c120355 into main Oct 19, 2023
8 checks passed
@chris-rock chris-rock deleted the dom/v8+v9-vuln branch October 19, 2023 07:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants