🐛 Fix vuln command panic #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #977 Signed-off-by: Christian Zunker <[email protected]>
|
Works again: |
imilchev
reviewed
Dec 5, 2023
| Features: conf.Features, | ||
| Asset: cliRes.Asset, | ||
| Upstream: runtime.UpstreamConfig, | ||
| }, nil) | ||
| }) | ||
| if err != nil { | ||
| log.Fatal().Err(err).Msg("could not load asset information") |
There was a problem hiding this comment.
can we remove the fatal here and follow the same pattern as here #900? We want to exit properly instead of panicking
There was a problem hiding this comment.
Not that easy. I gave it a try. The current structs do not support it. We would need to change cnquery, and than preferably also all the other commands associated with the struct: shell, run, and scan.
That would blow up this PR and log.Fatal already exits with os.Exit(1) and does not panic.
There was a problem hiding this comment.
alright, let's leave that out. Need to fix the tests though
Signed-off-by: Christian Zunker <[email protected]>
Signed-off-by: Christian Zunker <[email protected]>
Signed-off-by: Christian Zunker <[email protected]>
Signed-off-by: Christian Zunker <[email protected]>
imilchev
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #977