Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PREview update for improved stability #10

Merged
merged 6 commits into from
Mar 1, 2024
Merged

Conversation

benr
Copy link
Member

@benr benr commented Feb 29, 2024

Description

This PR is aimed at improving the stability of the PREview system used for creating ephemeral preview environments to improve the development experience. Specifically it:

  1. Creates a checksum from the branch name which becomes the name of the bucket (and thus PREview URL), which avoid problems with characters that are allowed in branch names but not in bucket names
  2. Reduces duplication of the bucket name generation scheme

Related issue

Types of changes

  • Functional documentation bug fix (i.e., broken link or some other busted behavior)
  • New functional doc capabilities (i.e., filter search results)
  • New content
  • Revision to existing content
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist

  • I have read the README document about contributing to this repo.
  • I have tested my changes locally and there are no issues.
  • All commits are signed.

@benr benr self-assigned this Feb 29, 2024
Copy link
Contributor

Starting creation of the PREview environment...

Copy link
Contributor

PREview environment has been created at https://mondoo-pre-docs-269526512.storage.googleapis.com/docs/index.html

Copy link
Contributor

@benr benr changed the title Benr/preview branch names PREview update for improved stability Feb 29, 2024
Copy link
Contributor

@misterpantz misterpantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@misterpantz misterpantz merged commit 70f6394 into main Mar 1, 2024
7 checks passed
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Cleaning up PREview environment...

@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
@tas50 tas50 deleted the benr/preview-branch-names branch September 6, 2024 22:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants