Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAIT FOR RELEASE --Add docs on SentinelOne integration #546

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

WAIT FOR RELEASE --Add docs on SentinelOne integration #546

wants to merge 10 commits into from

Conversation

misterpantz
Copy link
Contributor

@misterpantz misterpantz commented Jan 14, 2025 •
edited
Loading

Description

Related issue

Types of changes

  • Functional documentation bug fix (i.e., broken link or some other busted behavior)
  • New functional doc capabilities (i.e., filter search results)
  • New content
  • Revision to existing content
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist

  • I have read the README document about contributing to this repo.
  • I have tested my changes locally and there are no issues.
  • All commits are signed.

@github-actions GitHub Actions
Copy link
Contributor

Starting creation of the PREview environment...

@github-actions GitHub Actions
Copy link
Contributor

PREview environment has been created at https://mondoo-pre-docs-2832993549.storage.googleapis.com/docs/index.html
Please allow a few minutes for the environment to be fully deployed.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

PREview has been updated at https://mondoo-pre-docs-2832993549.storage.googleapis.com/docs/index.html

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

PREview has been updated at https://mondoo-pre-docs-2832993549.storage.googleapis.com/docs/index.html

@github-actions GitHub Actions
Copy link
Contributor

PREview has been updated at https://mondoo-pre-docs-2832993549.storage.googleapis.com/docs/index.html

@misterpantz misterpantz marked this pull request as ready for review January 17, 2025 23:44
@misterpantz misterpantz changed the title DRAFT Add docs on SentinelOne integration Add docs on SentinelOne integration Jan 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

PREview has been updated at https://mondoo-pre-docs-2832993549.storage.googleapis.com/docs/index.html

@github-actions GitHub Actions
Copy link
Contributor

PREview has been updated at https://mondoo-pre-docs-2832993549.storage.googleapis.com/docs/index.html

czunker
czunker approved these changes Jan 20, 2025
View reviewed changes
Copy link

@czunker czunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @misterpantz

static/img/platform/infra/imports/sentinelone/token.png Outdated Show resolved Hide resolved
@misterpantz misterpantz changed the title Add docs on SentinelOne integration WAIT FOR RELEASE --Add docs on SentinelOne integration Jan 21, 2025
@misterpantz
Copy link
Contributor Author

I've applied your changes, @czunker. Would you please review and re-approve? Thanks!!

@github-actions GitHub Actions
Copy link
Contributor

PREview has been updated at https://mondoo-pre-docs-2832993549.storage.googleapis.com/docs/index.html

@charlesjohnson
Copy link
Contributor

One bit of feedback on the scoping for the user in SentinelOne:

My first time creating an API user, I made an API user scoped on 'site' to start.

SITE --> Account --> Site, Viewer permissions.

This didn't work, I got 403's from SentinelOne when the integration tried to run.

I made a second API user scoped on Account --> Site, Viewer permissions, and this one worked.

Not sure what notes if any we need to make here to help, but I stubbed my toe on it.

@github-actions GitHub Actions
Copy link
Contributor

PREview has been updated at https://mondoo-pre-docs-2832993549.storage.googleapis.com/docs/index.html

@misterpantz
Copy link
Contributor Author

misterpantz commented Jan 29, 2025 •
edited
Loading

@charlesjohnson when was that? I ask because this morning I updated the docs per @czunker -- I now stress that you have to set scopes for an account, specifically not for a site. But if you followed the docs today and selected a site, then I need to be more emphatic. :)
Screenshot 2025-01-28 at 7 23 51 PM

@misterpantz
Copy link
Contributor Author

Oh I did just fix a typo in there!

@czunker
Copy link

czunker commented Jan 29, 2025

I've applied your changes, @czunker. Would you please review and re-approve? Thanks!!

👍 Thanks @misterpantz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czunker czunker czunker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@misterpantz @charlesjohnson @czunker