Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Use defined scanner image also for container scan #900

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Oct 26, 2023

When the MondooAuditConfig defiens a custom image, also use it for the container scan CronJob.

Fixes #887

When the `MondooAuditConfig` defiens a custom image, also use it for the container scan `CronJob`.

Fixes #887

Signed-off-by: Christian Zunker <[email protected]>
@czunker
Copy link
Contributor Author

czunker commented Oct 26, 2023

Also tried it locally:

k get -n mondoo-operator mondooauditconfigs.k8s.mondoo.com mondoo-client -o yaml | grep -A3 image                                                                --
    image:
      name: nginx
      tag: 1.25-alpine
k get -n mondoo-operator cronjob.batch/mondoo-client-containers-scan -o yaml | grep image                                                                     
            image: nginx:1.25-alpine

@czunker czunker requested a review from imilchev October 26, 2023 07:46
Copy link
Member

@imilchev imilchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice that we also have a test for this! :shipit:

@czunker czunker merged commit 74cf403 into main Oct 26, 2023
23 checks passed
@czunker czunker deleted the christian/fix_887 branch October 26, 2023 09:05
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container scan image is does not follow MondooAuditConifg overrides
2 participants