🧹 Add e2e OOM tests #944
Merged
🧹 Add e2e OOM tests #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czunker
force-pushed
the
christian/add_e2e_oom_tests
branch
from
4a21d0c to
26c717c
Compare
|
Finally, I found out why these tests are failing. We have a bug in the CronJob Schedule that makes these tests fail. The schedule for the k8s resource scan is constantly changed and this changes the number of expected objects in these tests. I assume we have the actual bug from the beginning of the CronJobs, but exposed it with #938. Need to find a fix for the schedule, before we can merge this PR. |
Merged
|
When tests pass for #948 and it is merged, this needs a rebase for tests to also succeed here. |
This adds e2e tests for OOM of Scan API and node scan. This covers the two different cases we currently have: Deployment and CronJob. Fixes #940 Signed-off-by: Christian Zunker <[email protected]>
Signed-off-by: Christian Zunker <[email protected]>
Signed-off-by: Christian Zunker <[email protected]>
czunker
force-pushed
the
christian/add_e2e_oom_tests
branch
2 times, most recently
from
a3dcea7 to
ccbe3ed
Compare
Signed-off-by: Christian Zunker <[email protected]>
czunker
force-pushed
the
christian/add_e2e_oom_tests
branch
from
ccbe3ed to
03339a9
Compare
imilchev
approved these changes
Nov 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds e2e tests for OOM of Scan API and node scan. This covers the two different cases we currently have: Deployment and CronJob.
Fixes #940