Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register plug-in as Packer integration #153

Merged
merged 14 commits into from
Jan 12, 2024
Merged

Conversation

nywilken
Copy link
Contributor

@nywilken nywilken commented Nov 22, 2023

👋 fellow Packer maintainer working on migrating your plugin to the Packer integration framework.

This change takes the necessary steps to register this plugin as an official Packer integration.
Integrations can be found on the Packer integration portal at https://developer.hashicorp.com/packer/integrations.


The pull-request consists of the following changes:

  • Adds controlling, metadata file, metadata.hcl for registering the plug-in and it components as integrations.
    Details on the contents, along with a description of the attributes, can be found at https://github.com/hashicorp/integration-template.
  • Adds the GitHub action workflows for triggering manual and automatic integration updates.
  • Restructures the plug-in documentation to match the expected format of the integration framework.
  • Adds a .web-docs directory for serving the fully render documentation as the integration docs.
  • Adds the build-docs make target make build-docs for syncing changes to the docs directory to the .web-docs directory.

Changes to the integration docs can be made at plugin release via the notify-integration-release-via-tag workflow or
manually by running the notify-integration-release-via-manual workflow.

Details on how the Integration framework pipeline works can be found at hashicorp/packer#12702

TODOs

  • Open pull-request against external plugin.
  • Update integration description .web-docs/metadata.hcl.
  • Packer team open internal pull-request to enable integration.
  • Review plugin integration on Packer integration portal .... Iterate

Copy link
Contributor

github-actions bot commented Nov 22, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@chris-rock
Copy link
Member

@nywilken @BrandonRomano Thank you for the help to move it to the packer integration portal. Once @BrandonRomano agreed to the CLA, we can merge it and take care of the spelling issues.

@chris-rock
Copy link
Member

@BrandonRomano is covered by the HashiCorp CLA. @benr can you help turn his CLA to green?

.web-docs/metadata.hcl Outdated Show resolved Hide resolved
@nywilken
Copy link
Contributor Author

@nywilken @BrandonRomano Thank you for the help to move it to the packer integration portal. Once @BrandonRomano agreed to the CLA, we can merge it and take care of the spelling issues.

Thank you @chris-rock. There are a few small updates that need to be made to complete the PR but please feel free to review the docs when you or the team have time. lbajolet-hashicorp will be assisting in getting this ready over the next couple of days.

@chris-rock
Copy link
Member

recheck

provisioner/provisioner.go Outdated Show resolved Hide resolved
@chris-rock
Copy link
Member

Happy new year @nywilken @BrandonRomano. Is there anything missing from your side, otherwise we would love to get this merged.

@nywilken
Copy link
Contributor Author

Hi @chris-rock thanks for bubbling this up. We are coming back from Holidays this week so catching up. Happy New Year. This PR is all good to go we enabled the integration on our end so you can merge and trigger the .github/workflows/notify-integration-release-via-manual.yaml job when ready with the existing plugin version.

Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chris-rock chris-rock merged commit 2995a24 into mondoohq:main Jan 12, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants