Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Auto approve cnspec bump PRs #328

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Nov 11, 2024

When we auto approve these, this will automatically trigger the release workflow. This will allow us to create a packer-plugin release each time we create a new cnspec release.

When we auto approve these, this will automatically trigger the release workflow.
This will allow us to create a packer-plugin release each time we create a new cnspec release.

Signed-off-by: Christian Zunker <[email protected]>
@@ -66,3 +66,35 @@ jobs:
env:
API_VERSION: x5.0
CNSPEC_VERSION: ${{ env.CNSPEC_VERSION }}

debug:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this later, but currently I might need some data from the dump, to check the workflow in case of an error.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm scared of us forgetting it and inadvertently dumping some secret in the future - can we comment this out for now and only add if if we really need it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@czunker czunker merged commit cde8358 into main Nov 11, 2024
5 checks passed
@czunker czunker deleted the czunker/auto_approve_cnspec_bump branch November 11, 2024 09:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants