Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added custom compliance framework upload and compliance framework (de)activation #108

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

Pauti
Copy link
Contributor

@Pauti Pauti commented Jun 7, 2024

No description provided.

@Pauti Pauti mentioned this pull request Jun 7, 2024
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Pauti This looks great. Lets do some naming improvements and we are good to go.

docs/resources/compliance_framework.md Outdated Show resolved Hide resolved
docs/resources/custom_compliance_framework.md Outdated Show resolved Hide resolved
internal/provider/gql.go Outdated Show resolved Hide resolved
@Pauti Pauti force-pushed the compliance_framework_resource branch from e75884c to b16b694 Compare June 17, 2024 08:37
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition @Pauti I added some comments for smaller improvements of the code.

internal/provider/compliance_framework_resource.go Outdated Show resolved Hide resolved
internal/provider/compliance_framework_resource.go Outdated Show resolved Hide resolved
internal/provider/compliance_framework_resource.go Outdated Show resolved Hide resolved
internal/provider/gql.go Show resolved Hide resolved
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Pauti Great addition.

@chris-rock
Copy link
Member

@chris-rock chris-rock merged commit bb2ab1a into mondoohq:main Jun 28, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants