✨ Add the new exclude fields for serverless AWS integration. Mark old fields as deprecated. #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Preslav <[email protected]>
preslavgerchev
force-pushed
the
preslav/more-v2-serverless
branch
from
15f9938 to
f7d1a58
Compare
preslavgerchev
changed the title
afiune
reviewed
Oct 15, 2024
| "ebs_volume_scan": schema.BoolAttribute{ | ||
| MarkdownDescription: "Enable EBS volume scan.", | ||
| Optional: true, | ||
| }, | ||
| "ebs_scan_options": schema.SingleNestedAttribute{ | ||
| Required: true, | ||
| Required: true, | ||
| DeprecationMessage: "This field is deprecated and will be removed in the future.", |
There was a problem hiding this comment.
Is not missing a flag here that indicates the argument is deprecated? Or just with this message it will detect it as deprecated?
There was a problem hiding this comment.
just by setting the message, there's no deprecated field
| "ebs_volume_scan": schema.BoolAttribute{ | ||
| MarkdownDescription: "Enable EBS volume scan.", | ||
| Optional: true, | ||
| }, | ||
| "ebs_scan_options": schema.SingleNestedAttribute{ | ||
| Required: true, | ||
| Required: true, |
There was a problem hiding this comment.
If this argument is deprecated, can we not make it a required field?
There was a problem hiding this comment.
Once removed, I'll approve!
|
|
||
| Optional: | ||
|
|
||
| - `ebs_volume_scan` (Boolean) Enable EBS volume scan. | ||
| - `exclude_instance_ids_filter` (List of String) List of instance IDs to exclude. | ||
| - `exclude_regions_filter` (List of String) List of regions to exclude. | ||
| - `exclude_tags_filter` (Map of String) Excluded Tags filter. |
There was a problem hiding this comment.
I wish we could have used a Set here to define a nested set of filters. Like:
filters {
exclude_tags = [""]
exclude_regions = [""]
exclude...
}Maybe in a new major version we can do this.
Signed-off-by: Preslav <[email protected]>
afiune
approved these changes
Oct 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.