Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update resource description #183

Merged
merged 3 commits into from
Dec 16, 2024
Merged

docs: update resource description #183

merged 3 commits into from
Dec 16, 2024

Conversation

jeff-d
Copy link
Contributor

@jeff-d jeff-d commented Dec 13, 2024

  • remove google reference
  • clarify scanning behavior

@jeff-d
docs: remove erroneous Google reference
d5833eb 
Signed-off-by: Jeff Deininger <[email protected]>
@jeff-d
docs: clarify scanning behavior
398ded9 
This terraofrm resource creates the Mondoo-hosted AWS integration. Use
the Serverless AWS integration to scan AWS Organizations with Mondoo.

References:
https://registry.terraform.io/providers/mondoohq/mondoo/latest/docs/resources/integration_aws_serverless

https://mondoo.com/docs/platform/infra/cloud/aws/aws-integration-scan/

Signed-off-by: Jeff Deininger <[email protected]>
@jeff-d jeff-d changed the title Aws-integration-resource docs: update resource description Dec 13, 2024
@chris-rock
Copy link
Member

@jeff-d Thank you very much. Can you run make generate to update all the dependent docs? https://github.com/mondoohq/terraform-provider-mondoo/blob/main/GNUmakefile#L20 This will turn the PR green

@scottford-io scottford-io requested a review from afiune December 16, 2024 18:17
afiune
afiune approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A rebase is needed to clear the pipeline, since it's a documentation change, I'll merge it as is.

@afiune afiune merged commit 112773f into main Dec 16, 2024
14 of 19 checks passed
@afiune afiune deleted the aws-integration-resource branch December 16, 2024 19:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@afiune afiune afiune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeff-d @chris-rock @afiune