Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings>Interface: add sections, rename labels, add language #2710

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Settings>Interface: add sections, rename labels, add language #2710

wants to merge 1 commit into from

Conversation

rating89us
Copy link
Contributor

@rating89us rating89us commented Jan 9, 2020 •
edited
Loading

Closes #2651

  • Add sections Security and Appearance
  • Change "After * minutes" to "after * minutes", move text to the same line as "Lock wallet on inactivity"
  • Slider is now always visible
  • Add item Language
  • Change language button now is always visible
  • Add "Use" verb in "Light theme" item
  • Add "Use" verb in "Custom decorations" item
  • Change text to "Display balance in other currency"

image

Previous:
image

@selsta
Copy link
Collaborator

selsta commented Jan 9, 2020

Nice. Here is some feedback:

  • Security and Appearance don’t have the same bottom margin.
  • The language text and button feel a bit out of place. Maybe this can be made visually nicer.
  • Please use spaces for indentation. It appears that in some places you mix tabs and spaces. Also check if the indentation is correct everywhere.

@rating89us rating89us force-pushed the settings-interface branch 2 times, most recently from b7d2f95 to 92032ad Compare January 14, 2020 00:45
@rating89us
SettingsLayout: add sections, rename labels, add language
247e218 
* Add sections Security and Appearance
* Change "After * minutes" to "after * minutes", move text to the same line as "Lock wallet on inactivity"
* Slider always visible
* Add item Language
* Change language button always visible
* Add "Use" verb in "Light theme" item
* Add "Use" verb in "Custom decorations" item
* Change text to "Display balance in other currency"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings > Interface: redesign
2 participants
@rating89us @selsta