feat: update atlas cluster states COMPASS-8228 #6884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syn-zhu
changed the title
syn-zhu
changed the title
syn-zhu
changed the title
This reverts commit 2a14569.
Anemy
reviewed
May 1, 2025
| @@ -48,7 +48,7 @@ export interface AtlasClusterMetadata { | |||
| | 'UPDATING' | |||
| | 'PAUSED' | |||
| | 'IDLE' | |||
| | 'REPARING' | |||
| | 'REPAIRING' | |||
| | 'DELETING' | |||
| | 'DELETED'; | |||
There was a problem hiding this comment.
There's a related comment above, is SUCCESSor WORKING a state we want to have here? Where's the source of truth for these?
It's not this right?
https://github.com/10gen/mms/blob/8f63b6c6e79f50a310a662260131f2f05818cdd8/server/src/main/com/xgen/cloud/nds/project/_public/model/ClusterDescription.java#L4681
There was a problem hiding this comment.
Comment on lines
20
to
21
| const storeRef = useRef(useStore()); | ||
| const [ref] = useState(() => { |
There was a problem hiding this comment.
Would this be a cleaner way to write this?
const store = useStore();
const getConnectable = useCallback((connectionId: string) => {
// ...
}, [store]);Fine as is too I think.
There was a problem hiding this comment.
Ah, would that have the same outcome?
Anemy
reviewed
May 2, 2025
packages/compass-connections/src/stores/connections-store-redux.ts
Outdated
Show resolved
Hide resolved
Anemy
approved these changes
May 2, 2025
| @@ -1399,7 +1427,9 @@ function getDescriptionForNonRetryableError(error: Error): string { | |||
| // to the generic error description. | |||
| const reason = error.message.match(/code: \d+, reason: (.*)$/)?.[1]; | |||
| return reason && reason.length > 0 | |||
| ? reason | |||
| ? reason.endsWith('.') | |||
| ? reason.slice(0, -1) | |||
There was a problem hiding this comment.
TIL negative numbers work with slice
|
Err once unit tests are green and we should probably add some tests of our own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/COMPASS-8228
Description
Screen.Recording.2025-04-30.at.5.30.46.PM.mov
Screen.Recording.2025-04-30.at.5.33.21.PM.mov
Screen.Recording.2025-04-30.at.5.44.29.PM.mov
Checklist
New tests and/or benchmarks are included
Documentation is changed or added
If this change updates the UI, screenshots/videos are added and a design review is requested
I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)
Motivation and Context
Open Questions
Dependents
Types of changes