Skip to content

fix: fork checks #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025
Merged

fix: fork checks #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6adc3d8
fix: fork checks
fmenezes May 2, 2025
36f6941
fix: remove from code_health
fmenezes May 2, 2025
fb10f21
fix: join npm ci with dev deps
fmenezes May 2, 2025
0d987aa
fix: no wait for dependabot PR
fmenezes May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion .github/workflows/lint.yml → .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
---
name: Lint
name: Checks
on:
push:
branches:
- main
pull_request:
pull_request_target:
branches:
- main

permissions: {}

Expand Down Expand Up @@ -35,3 +38,21 @@ jobs:
- name: Install dependencies
run: npm ci
- run: npm run generate

check-dep:
name: Check dependencies
runs-on: ubuntu-latest
steps:
- uses: GitHubSecurityLab/actions-permissions/monitor@v1
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: package.json
cache: "npm"
- name: Install dependencies, build and remove dev dependencies
run: |
npm ci
rm -rf node_modules
npm pkg set scripts.prepare="exit 0"
npm install --omit=dev
- run: npx -y @modelcontextprotocol/inspector --cli --method tools/list -- node dist/index.js --connectionString "mongodb://localhost"
20 changes: 0 additions & 20 deletions .github/workflows/code_health.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,26 +62,6 @@ jobs:
name: atlas-test-results
path: coverage/lcov.info

dep-check:
name: Check dependencies
if: github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository
runs-on: ubuntu-latest
steps:
- uses: GitHubSecurityLab/actions-permissions/monitor@v1
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version-file: package.json
cache: "npm"
- name: Install dependencies & build
run: npm ci
- name: Remove dev dependencies
run: |
rm -rf node_modules
npm pkg set scripts.prepare="exit 0"
npm install --omit=dev
- run: npx -y @modelcontextprotocol/inspector --cli --method tools/list -- node dist/index.js --connectionString "mongodb://localhost"

coverage:
name: Report Coverage
if: always() && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/code_health_fork.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ jobs:
permissions:
pull-requests: write
contents: write
needs:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by: no need, PRs will wait for tests

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any harm in keeping it though. If we decide to remove these checks for whatever reason we don't want the dependabot to pop up and actually do this

- run-tests
steps:
- name: Enable auto-merge for Dependabot PRs
run: gh pr merge --auto --squash "$PR_URL"
Expand Down
Loading