(EAI-868 & EAI-869): HuggingFace uploader & upload the docs dataset to HuggingFace #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlarew
reviewed
Feb 18, 2025
packages/datasets/src/EnvVars.ts
Outdated
Comment on lines
1
to
6
| export const OPENAI_ENV_VARS = { | ||
| OPENAI_API_KEY: "", | ||
| OPENAI_ENDPOINT: "", | ||
| OPENAI_CHAT_COMPLETION_DEPLOYMENT: "", | ||
| OPENAI_API_VERSION: "", | ||
| }; |
There was a problem hiding this comment.
Not a big deal - any reason to use this over importing CORE_OPENAI_CONNECTION_ENV_VARS and/or CORE_OPENAI_CHAT_COMPLETION_ENV_VARS (we can probably remove OPENAI_CHAT_COMPLETION_MODEL_VERSION from this)
There was a problem hiding this comment.
i think it was for specificity? not sure. this prob vestigate of hacking around. will clean up to use CORE_OPENAI_CONNECTION_ENV_VARS unless there's a clear reason that comes up not to do this.
nlarew
reviewed
Feb 18, 2025
packages/datasets/src/bin/huggingFace/uploadContentDatasetToHuggingFace.ts
Outdated
Show resolved
Hide resolved
nlarew
reviewed
Feb 18, 2025
nlarew
reviewed
Feb 18, 2025
nlarew
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira:
Changes
uploadDatasetToHuggingFace()to upload datasets to HuggingFaceNotes