-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-33503) Unhide Find Your App ID CLI procedure #619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM - I just noticed we're using different tab groups here, which means inconsistent tab naming and it also means that when a user clicks the CLI tab in the first procedure, we're not showing the CLI tab in the second procedure. Maybe we should switch the second procedure to use the same tab group?
source/apps/metadata.txt
Outdated
@@ -188,7 +192,7 @@ or Atlas CLI to find it programmatically. | |||
:alt: Expanded ellipses icon showing the Actions menu and the copy | |||
:width: 400px | |||
|
|||
.. tab:: Atlas CLI | |||
.. tab:: CLI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I noticed the tab title on the page for the procedure we're un-hiding above is "App Services CLI" and the tab title of this procedure is just "CLI." It looks like we're using .. tabs-realm-admin-interfaces::
above, and for this procedure, we're just using .. tabs::
in ln 155. Should we use the same tab group as above for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This procedure can't use the realm-admin-interfaces tabset because it's using all the Atlas stuff. It'd be cool if we could link the App Services CLI and Atlas CLI tabs together but alas they are not currently connected.
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/atlas-app-services/master/ 🪵 Logs |
Pull Request Info
Jira
Staged Changes