Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DOCSP-33503) Unhide Find Your App ID CLI procedure #619

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

nlarew
Copy link
Contributor

@nlarew nlarew commented Nov 1, 2023

Pull Request Info

Jira

Staged Changes

Copy link
Collaborator

@dacharyc dacharyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM - I just noticed we're using different tab groups here, which means inconsistent tab naming and it also means that when a user clicks the CLI tab in the first procedure, we're not showing the CLI tab in the second procedure. Maybe we should switch the second procedure to use the same tab group?

@@ -188,7 +192,7 @@ or Atlas CLI to find it programmatically.
:alt: Expanded ellipses icon showing the Actions menu and the copy
:width: 400px

.. tab:: Atlas CLI
.. tab:: CLI
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I noticed the tab title on the page for the procedure we're un-hiding above is "App Services CLI" and the tab title of this procedure is just "CLI." It looks like we're using .. tabs-realm-admin-interfaces:: above, and for this procedure, we're just using .. tabs:: in ln 155. Should we use the same tab group as above for consistency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This procedure can't use the realm-admin-interfaces tabset because it's using all the Atlas stuff. It'd be cool if we could link the App Services CLI and Atlas CLI tabs together but alas they are not currently connected.

@nlarew nlarew merged commit bb41c34 into mongodb:master Nov 6, 2023
4 checks passed
@nlarew nlarew deleted the unhide branch November 6, 2023 21:55
@docs-builder-bot
Copy link

MongoCaleb pushed a commit to MongoCaleb/docs-app-services that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants